Fixes needed for livemedia-creator and anaconda --dirinstall #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the mountpoint and the rc value to the FSError message. Details and output of lsof are still available in program.log, this just makes the error more clear to whoever catches it.
Otherwise it will try to unmount things that shouldn't be unmounted.
|
These both look good to me. |
|
pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipping device teardown is a bit of a hack, but it solves the problem for the moment. We need to look at how mountpoints are being handled and fix that at some point soon. It is nuts that repeated calls to teardown can result in different behavior.