Edd more testcases #262
Closed
Edd more testcases #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vathpela
force-pushed
the
edd-more-testcases
branch
4 times, most recently
from
ef96bf8
to
b574168
Compare
|
Other than those few comments I think I'm ok with this. Other eyes would be good, I'm afraid I didn't actually read every single line :) |
vathpela
force-pushed
the
edd-more-testcases
branch
4 times, most recently
from
57e551a
to
60ab01d
Compare
I'm just so, so tired of futzing around with os.path.join() and os.path.normalize() not doing their jobs usefully. This version of normalize doesn't try to resolve .. or symlinks; it only de-dupes slashes. I can't find anywhere we depend on resolving .. or symlinks, so it's just not as pretty as it could be. So basically if you need to normalize slashes, use util.normalize_path_slashes() . If you need to resolve symlinks, use os.path.normalize() Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Peter Jones <pjones@redhat.com>
This also makes path joining simpler, and automagically normalizes slashes reasonably. Signed-off-by: Peter Jones <pjones@redhat.com>
Because seriously, code shouldn't have to care about if we do
get_sysfs_attr("/sys/foo/","bar") or get_sysfs_attr("/sys/foo","/bar")
This also makes these functions able to deal with an alternate root
directory separately from the sysfs path.
Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Peter Jones <pjones@redhat.com>
It's really annoying that there's no way to turn off unittest.assertEqual()'s stupid string truncation, and it makes it very difficult to debug test failures that involve a fairly large amount of data. So replace it with something that tells us the meaningful bits. Signed-off-by: Peter Jones <pjones@redhat.com>
This lets us tell (and log) which edd entry we're probing. Signed-off-by: Peter Jones <pjones@redhat.com>
This gets rid of EddEntry._sysfsroot and the sysfsroot property entirely, because we don't need these at all any more with our Path object. This also tries to limit how much we manually interpolate the fsroot. Signed-off-by: Peter Jones <pjones@redhat.com>
This way we can be sure we collect them for test cases. Signed-off-by: Peter Jones <pjones@redhat.com>
This is probably always indicative of a bug in firmware or our matcher, but that's still worth the logging. Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Peter Jones <pjones@redhat.com>
The problem is that SeaBIOS (and thus our qemu VMs) doesn't enumerate ata devices separately from PCI devices. So on a real system, EddEntry.ata_device should reset to 0 for each new PCI device, but on a virt running SeaBIOS, they just count up monotonically. So do the /right/ thing when we can, and if we don't find a correct device, try relaxing the requirement on the scsi target id in sysfs, and see if we find the right port number anyway. Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Peter Jones <pjones@redhat.com>
So apparently if it actually shows the EDDv3 info on a SATA drive, it's just a matter of luck. Signed-off-by: Peter Jones <pjones@redhat.com>
This is data for seabios with https://github.com/vathpela/seabios/tree/edd applied to try and actually make EDD work on our virtual machines. Signed-off-by: Peter Jones <pjones@redhat.com>
vathpela
force-pushed
the
edd-more-testcases
branch
from
60ab01d
to
4f0aa2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds (on top of PR #261) a bunch more EDD test cases from various physical and virtual machines I've found.