Add PEP8 compliance checking to 'check' target. #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwlehman
force-pushed
the
pep8-check
branch
4 times, most recently
from
f5c0a92
to
758a08e
Compare
|
Looks good to me. It's nice to have pep8 testing. |
|
Looks good to me otherwise. |
Moves 'pylint' to its own target, adds a 'pep8' target, and makes the 'check' target empty with 'check' and 'pep8' as prerequisites. This allows the user to run either pylint or pep8 separately or together. It also makes it possible to plumb a user-specified PYTHONPATH into the 'pylint' target. We are currently ignoring errors for overly-long lines, hence the '--ignore E501'.
dwlehman
added a commit
that referenced
this pull request
Nov 19, 2015
Add PEP8 compliance checking to 'check' target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves 'pylint' to its own target, adds a 'pep8' target, and makes
the 'check' target empty with 'check' and 'pep8' as prerequisites.
This allows the user to run either pylint or pep8 separately or
together.
It also makes it possible to plumb a user-specified PYTHONPATH
into the 'pylint' target.