Update the getattr calls with PEP8 property/attribute names #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to have a nicer code we have recently moved from camelCase names to split_words names. While the change covered all the direct accesses (pylint would catch any problematic ones), it didn't cover the cases where we access the items indirectly via the getattr() call. This fixes all the getattr() calls that tried to access any camelCase items.
|
Thanks for fixing this. |
vpodzime
added a commit
that referenced
this pull request
Nov 13, 2015
Update the getattr calls with PEP8 property/attribute names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have a nicer code we have recently moved from camelCase names to
split_words names. While the change covered all the direct accesses (pylint
would catch any problematic ones), it didn't cover the cases where we access the
items indirectly via the getattr() call. This fixes all the getattr() calls that
tried to access any camelCase items.