Master pylint #36
Closed
Master pylint #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting LC_ALL=C should avoid any differences due to different locales. Sort order seems a bit more sensible for programming. Signed-off-by: mulhern <amulhern@redhat.com>
This is the precise error the invoked functions are returning and GError is a more precise match than Error in false positives. Signed-off-by: mulhern <amulhern@redhat.com>
This is another false positive resulting from pylint's inability to find GLib in gi.repository. Signed-off-by: mulhern <amulhern@redhat.com>
|
These look fine to me and take care of an issue I am seeing in jenkins. |
|
Pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some pylint related changes. If there's a better way to sort that is more consistant across all locales,
let me know.