Some low-hanging fruit to speed reset() up #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be faster than our custom code which currently brings no real advantage as we don't want to support some random formats given to us by somebody else.
|
The tests failure is the same old unrelated issue with the |
|
Jenkins, please test this. |
|
These all look ok to me. |
|
Jenkins, please test this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three small and simple changes that make
reset()quite a bit faster (~3s on my testing VM). A lot more can/needs to be done in the future, but the rest is quite complicated.Just a note for the second patch:
resolve_devspec()is not needed there. Something likeresolve_dev_symlink()would be sufficient and much more efficient, but since it is a common operation, I'd like to add such function to libblockdev and then do the change in Blivet to start using it.