formats/fs: Set NTFS to be formattable #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During running the test suite I found that while MKNTFS_APP is available, the tests for NTFS are skipped because it's not marked to be formattable. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
aszlig
added a commit
to NixOS/nixpkgs
that referenced
this pull request
Jan 15, 2017
Even though the ntfs3g utilities are available inside our test environment, the format didn't get advertised as formattable because the _formattable attribute wasn't set to True. Submitted upstream at: storaged-project/blivet#536 Signed-off-by: aszlig <aszlig@redmoonstudios.org>
|
Jenkins, ok to test. |
|
The test failures are unrelated to these changes. @dwlehman: I think I remember some discussion about this, is there some reason for not having NTFS formattable? |
|
Jenkins, test this, please. |
vpodzime
approved these changes
Jan 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During running the test suite I found that while
MKNTFS_APPis available, the tests for NTFS are skipped because it's not marked to be formattable.