Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'discard' option to crypttab for newly created LUKS #550

Merged
merged 1 commit into from Mar 13, 2017

Conversation

vpodzime
Copy link
Contributor

@vpodzime vpodzime commented Mar 2, 2017

As has been suggested and approved in the Fedora 26 change
https://fedoraproject.org//wiki/Changes/EnableTrimOnDmCrypt,
crypttab entries for newly created LUKS devices/formats should
use the 'discard' option by default.

As has been suggested and approved in the Fedora 26 change
https://fedoraproject.org//wiki/Changes/EnableTrimOnDmCrypt,
crypttab entries for newly created LUKS devices/formats should
use the 'discard' option by default.
Copy link
Member

@vojtechtrefny vojtechtrefny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@vpodzime vpodzime requested a review from dwlehman March 6, 2017 07:54
Copy link
Contributor

@dwlehman dwlehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I need to find a way to make github be louder in telling me a review has been requested.

@vpodzime vpodzime merged commit 87ec500 into storaged-project:2.1-devel Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants