Ignore parted warnings if possible #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to work but I have a hard time creating a test case that throws a parted warning so I gave up on it. |
vpodzime
requested changes
Jun 15, 2017
src/plugins/part_err.c
Outdated
| /* | ||
| * Only treat exceptions as errors if they aren't at least errors or can't | ||
| * be ignored. | ||
| */ |
There was a problem hiding this comment.
aren't should be are, shouldn't it?
src/plugins/part_err.c
Outdated
| return PED_EXCEPTION_UNHANDLED; | ||
| } | ||
| g_warning ("[parted] %s", ex->message); | ||
| return PED_EXCEPTION_IGNORE; |
There was a problem hiding this comment.
I'd prefer if the logic was inverted here. So something like if THIS_CAN_BE_IGNORED -> ignore; else raise
Ignore parted exceptions of type warning or information if parted marks them as ignorable.
|
There you go. |
|
Jenkins, this is ok to test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore parted exceptions of type warning and information if parted marks them as ignorable. Fixes #214.
I haven't tested this yet *cough*. Plus I should probably add at least one test case in which a parted warning is ignored. So please don't merge yet.