F24 lmc ostree #117
Closed
F24 lmc ostree #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make sure that a --make_pxe_live --no-virt doesn't use autopart or other mountpoints.
Instead of a partitioned disk image. This will allow a single pass of lmc to be used to create an ostree live PXE image.
This moves the mounting inside make_live_images so that it isn't trying to copy the fsimage while having it mounted.
umount tries to delete a mountpoint if it has lorax.imgutils in the path. This doesn't work right if you try to umount something mounted deeper on the path. This adds a delete option, which is True by default, to skip the delete.
This makes sure the contents of /boot are at the expected locations in /boot and in sys_root. For partitioned images it mounts the separate /boot partition on /boot. For both fsimage and partitioned images ir binf mounts it to sys_root so that the kernel+initrd can be found. The boot directory isn't always named boot.0, so wildcard it and let the count check handle failure if there is more than 1.
Because --no-virt uses a fsimage disk you can't create a /boot partition. This kickstart will also work for creating the PXE files inside a mock environment. Also rename rhel-atomic-pxe-live.ks to fedora-atomic-pxe-live.ks
|
AFAICT this looks good to me. |
|
Pushed to master only, too much change for post-freeze F24. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches allow livemedia-creator --no-virt (and --no-virt inside a mock) to be used for --make-pxe-live and --make-ostree-live