Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include cryptsetup in the image (#1208214) #14

Merged
merged 1 commit into from Apr 2, 2015
Merged

Conversation

bcl
Copy link
Contributor

@bcl bcl commented Apr 2, 2015

blivet dropped its requirement on cryptsetup, but fedup needs it in the
upgrade.img and it is useful for rescue mode so add it back.

blivet dropped its requirement on cryptsetup, but fedup needs it in the
upgrade.img and it is useful for rescue mode so add it back.
@AdamWill
Copy link
Contributor

AdamWill commented Apr 2, 2015

FWIW rescue mode actually works OK without this - it can mount encrypted installs, at least, as it uses blivet to do it. Once you have the installed system mounted you can use the cryptsetup it contains.

If for whatever reason you wanted to set up or manipulate an encrypted device from the rescue environment yourself using the cryptsetup tools, though, you could not.

This should certainly fix the upgrade.img case, though - I don't know whether this is the most-correct way to do it or not, but it should certainly work, so +1 from me for that.

@bcl bcl merged commit 92808bc into weldr:f22-branch Apr 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants