Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill fedup #41

Closed
wants to merge 2 commits into from
Closed

Kill fedup #41

wants to merge 2 commits into from

Conversation

wgwoods
Copy link
Contributor

@wgwoods wgwoods commented Aug 19, 2015

These patches make lorax stop building upgrade.img and stop requiring fedup-dracut and friends.

For backward-compatibility, the API and CLI have been left unchanged. --noupgrade is still accepted and doupgrade still gets passed into the templates. It just doesn't do anything.

This is intended for f23-branch and master, so it might need backporting.

NOTE: there's one place in pylorax/__init__.py that might want some tweaking:

        # ppc64 cannot boot an initrd > 32MiB so remove some drivers
        if self.arch.basearch in ("ppc64", "ppc64le"):
            dracut_args.extend(["--omit-drivers", REMOVE_PPC64_DRIVERS])

            # Only omit dracut modules from the initrd so that they're kept for
            # upgrade.img
            anaconda_args.extend(["--omit", REMOVE_PPC64_MODULES])

As far as I can tell, though, that shouldn't hurt anything

fedup is deprecated and abandoned. Let's save time and disk by not
building `upgrade.img` when nothing is going to use it anymore.

For the record, performing upgrades using an initramfs from the new
system turns out to be fragile and hard to support:

* dracut initramfs isn't generic enough to handle booting all systems
  (e.g. missing vconsole.conf means you get keymaps wrong, so users
  can't unlock encrypted disks)

* The ABI differences between the two versions of plymouth, systemd,
  etc. requires nasty workarounds at best and causes nightmarish
  systemd crashes at worst

This patch removes all the code that built and installed `upgrade.img`.

For backwards compatibility, the API retains the `doupgrade` keyword
argument, and the `--noupgrade` flag is still accepted.
This package will not exist soon. Don't bother trying to install it.
@jkonecny12
Copy link
Contributor

Seems good to me but I think @bcl should see this.

BTW when the funeral will be?

@wgwoods
Copy link
Contributor Author

wgwoods commented Aug 25, 2015

BTW when the funeral will be?

Once the packages are officially dead - hopefully when the clock strikes F23 - we'll say a few words, close all the bugs, and then drink a lot of whiskey.

@bcl bcl added the ACK label Aug 25, 2015
@bcl
Copy link
Contributor

bcl commented Aug 25, 2015

Great idea :) I also like how most of the changes are in the templates.

@bcl
Copy link
Contributor

bcl commented Sep 1, 2015

pushed.

@bcl bcl closed this Sep 1, 2015
@wgwoods wgwoods deleted the kill-fedup branch September 1, 2015 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants