feat: Adds support for custom metadata #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assigning metadata for files will be beneficial to find files. ref: https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/add-origin-custom-headers.html
|
haven't added any test cases to cover this patch. |
rhnvrm
requested changes
Jul 19, 2021
rhnvrm
reviewed
Jul 19, 2021
- metadata moved to UploadInput as optional field. - changed x-amz-meta as constant - changed sprintf to simple string concat
rhnvrm
reviewed
Jul 19, 2021
simples3.go
Outdated
| @@ -286,14 +287,18 @@ func (s3 *S3) FileDownload(u DownloadInput) (io.ReadCloser, error) { | |||
| return res.Body, nil | |||
| } | |||
|
|
|||
| const amzMeta = "x-amz-meta-" | |||
There was a problem hiding this comment.
Let's move this to the top of the file. Also, expose this as AMZMetaPrefix.
rhnvrm
changed the title
changed variable name for amazon meta prefix to the top, prefix variable is exported. removed redundant comment for metadata
joicemjoseph
force-pushed
the
feat/upload-metadata
branch
from
69664dd
to
d6ea1c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assigning metadata for files will be beneficial to
find files.
ref: https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/add-origin-custom-headers.html