Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure no extra columns display in the listing. #153

Closed
samussiah opened this issue Jun 26, 2019 · 3 comments · Fixed by #157
Closed

Ensure no extra columns display in the listing. #153

samussiah opened this issue Jun 26, 2019 · 3 comments · Fixed by #157
Projects
Milestone

Comments

@samussiah
Copy link
Contributor

samussiah commented Jun 26, 2019

i.e. make sure the number of columns matches the number of headers

Test notes

  • Download the cat dataset, add a column with the header "open_time", fill its cells with some string, and upload the updated dataset to cat.
  • Verify the listing has one header per column - no columns should be missing a header
  • Verify that the "Query Recency" Filter only has the string you added in the cells of the open_time column in it.
@samussiah samussiah added this to To do in v2.1.3 via automation Jun 26, 2019
@samussiah samussiah added this to the v2.1.3 milestone Jun 26, 2019
@pburnsdata pburnsdata moved this from To do to In progress in v2.1.3 Jul 18, 2019
@pburnsdata
Copy link
Contributor

I'm guessing that in Heather's situation, there was a column of data that didn't have a header. Going to update it to drop columns that lack headers and print a warning to the console.

@pburnsdata pburnsdata moved this from In progress to Reviewer approved in v2.1.3 Jul 18, 2019
@pburnsdata pburnsdata moved this from Reviewer approved to Done in v2.1.3 Jul 18, 2019
@pburnsdata
Copy link
Contributor

No longer dropping headerless columns, per Spencer: "In RhoMAP, the dataset already has a query recency column, so two columns with the same header (Query Recency) were causing the trouble here. Since the derived query recency variable is set to the provided query recency variable, we don't need both to appear in the listing."

@dschwentker
Copy link

Tested and passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v2.1.3
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants