Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right Click Option for specific streamer #7

Closed
BayleeYo opened this issue Jan 9, 2021 · 4 comments · Fixed by #8
Closed

Right Click Option for specific streamer #7

BayleeYo opened this issue Jan 9, 2021 · 4 comments · Fixed by #8

Comments

@BayleeYo
Copy link

BayleeYo commented Jan 9, 2021

https://www.twitch.tv/kittyjuicertv

Streamer: KittyjuicerTV

When I right click on player and click twitch in menu. It takes me to https://www.twitch.tv/null

When I search streamer in the plugin sidebar. It takes me to the correct URL listed at top of this issue.

PS> Yall rock for this plugin :D

@BayleeYo
Copy link
Author

Just found another player on the list
https://www.twitch.tv/xilLuZioNisTx
67 Gtos Rule

They also are pulling up Null when clicking twitch in game. This player/streamer was not currently streaming. The player above (Kitty) was live.

Could this be for everyone?

@rhoiyds
Copy link
Owner

rhoiyds commented Jan 10, 2021

You're absolutely right. Working on this right away - I have a hunch for what the problem may be.

@rhoiyds rhoiyds linked a pull request Jan 10, 2021 that will close this issue
@BayleeYo
Copy link
Author

Awesome! I appreciate you working hard and taking care of it!

@rhoiyds
Copy link
Owner

rhoiyds commented Jan 10, 2021

The issue is fixed, tested and working. (RuneLite devs will review it and the update should go live in no more than 12 hours or so from now)
To summarize: the issue was that players with spaces in their names actually don't have 'spaces' in Jagex's code, they have a NBSP instead (almost like a 'tab' character).
The plugin was trying to find a streamer 'John(space)Smith', but according to Jagex it's actually 'John(nbsp)Smith'. (Hence NULL)
Thanks again for being an absolute legend and reporting this issue.
If you ever find anything wrong, or have any feature suggestions please have no hesitations in coming here and logging them! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants