Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checkstyle using wildfly-checkstyle-config #69

Merged
merged 1 commit into from Nov 26, 2014

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Nov 24, 2014

No description provided.

@stefannegrea
Copy link
Contributor

There are some Eclipse profiles that sneaked in. I would like to keep the poms clean of any Eclipse stuff.

@ppalaga
Copy link
Contributor Author

ppalaga commented Nov 24, 2014

@stefannegrea, thanks for the hint! Fixed and force-pushed.

@ppalaga
Copy link
Contributor Author

ppalaga commented Nov 25, 2014

This PR was acked on rhq-devel list. Could it please be merged?

@tsegismont
Copy link
Contributor

Re-triggered Travis build

@tsegismont
Copy link
Contributor

I'm in favor of

<checkstyleFailOnError>true</checkstyleFailOnError>

@ppalaga
Copy link
Contributor Author

ppalaga commented Nov 25, 2014

@tsegismont , I have no problem with <checkstyleFailOnError>true</checkstyleFailOnError> but I'd do that in a separate PR together with the violations fixed.

tsegismont added a commit that referenced this pull request Nov 26, 2014
Added checkstyle using wildfly-checkstyle-config
@tsegismont tsegismont merged commit d481381 into hawkular:master Nov 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants