Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer Installation Path Differs from WordPress Repository Path #39

Closed
alpipego opened this issue Aug 11, 2016 · 4 comments
Closed

Composer Installation Path Differs from WordPress Repository Path #39

alpipego opened this issue Aug 11, 2016 · 4 comments

Comments

@alpipego
Copy link

alpipego commented Aug 11, 2016

As the title says, when installing the plugin from github via composer (as I did to get the fix for #36) the same include path does not work because it checks for WP_PLUGIN_DIR . '/redis-cache/includes/predis.php. With composer (from github) the plugin resides in /redis-object-cache/.
I am aware of a workaround (targeting this package explicitly in installer-paths), what do you think would be a viable solution to this? Changing the composer package name?

@tillkruss
Copy link
Member

I'm not sure, I never installed the plugin via Composer. What do you have in mind?

@alpipego
Copy link
Author

alpipego commented Aug 11, 2016

The easiest solution for me (and all future installers) would be to change the package name to tillkruss/redis-cache. You could mark the package tillkruss/redis-object-cache as "abandoned" and superseeded by tillkruss/redis-cache.

I can't tell you however if (or how much) that'll cause problems for users already installing via composer from github. It shouldn't however, cf. https://packagist.org/packages/quandigital/wp-libs

@alpipego
Copy link
Author

And composer would even warn the user:

screenshot 2016-08-11 17 24 00

@tillkruss
Copy link
Member

Thanks, I'll will do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants