Jmx adapter #431

skarsaune · 2020-02-13T21:32:19Z

Attempt to create a MBeanServerConnection proxy using jolokia as the actual backend, with fairly complete test coverage of what you get out of the box in a Java VM. More third party MBeans can be added to increase test coverage of problematic cases.
Tries to mimic exceptions and response values as closely as possible to JSR-160 connection.
Introduces a new internal dependency to jolokia-core from test to compile in order to reuse mapping to OpenType,
if that dependency is a problem the new adapter can be split out to a separate module.
Also wondering if one should automate tests with different old releases of the Jolokia JVM agent and possibly different JVM versions in github actions, to test permutations of clients and server.

Signed-off-by: Martin Skarsaune <martin@skarsaune.net>

…an be tested 1:1 , a few tests still remain

…when running in mvn

rhuss · 2020-02-14T22:21:13Z

Hey Martin, thanks a tons for all your work and dedication ! Let me try to jump on this, but this might take a bit. Hope to come to this next week, but there's a lot work on my plate these days ;-)

But that's all really very cool. Were you able to run this adapter in e.g. jconsole or visualvm ?

skarsaune · 2020-02-15T20:15:13Z

Hey Martin, thanks a tons for all your work and dedication ! Let me try to jump on this, but this might take a bit. Hope to come to this next week, but there's a lot work on my plate these days ;-)

But that's all really very cool. Were you able to run this adapter in e.g. jconsole or visualvm ?

Looking into running in jmc, but that is a big task in itself. No need to rush, I can try the jmc integration with a local snapshot, and it will probably result in adjustments as well.

…lilitate integration in jmc

… and jvisualvm by adding to classpath (DOES NOT work particularly well at this stage)

skarsaune · 2020-02-18T09:46:33Z

Have been testing directly in jconsole and jvisualvm by adding to classpath and using jmx url for example service:jmx:jolokia://localhost:9091/hawtio/jolokia/
plenty of stuff needs ironing out, plenty of adjustments probably. If it turns out to be not feasible, may shift focus to flight recordings from jmc as that was the original goal

rhuss · 2020-02-18T10:39:31Z

@skarsaune no worries, don't get lost. I haven't heard many requests about jconsol / jsvisualvm recently, so please focus what you need for your use case. If jvisualvm or jconsole support is requested, it still can be added later.

rhuss · 2020-02-18T10:40:15Z

wrt to a review, I can't jump on it until the over next week (busy this week, pto next). So please ping me again in case I should forget.

Thanks !

skarsaune · 2020-02-18T12:01:56Z

I will stay on the JConsole track a few more days, it is a nice real world example and the code is easily accessible within the JDK, so it is a fruitful excercise anyway. With regards to review I would hold off a bit, things may change quite a lot. Thought I could label it as draft, but do not find that option. Anyway I can notify when I believe things are more stable.

…ction as reference connection

…le adjustments

…vms, and allow values in payload not covered

rhuss · 2020-02-29T18:53:00Z

Good timing, just back from PTO ;-) (well, if it's good timing we will see when the e-mail backslash will he me :)

I will try to find a slot next week to jump on a review ...

skarsaune · 2020-03-01T20:39:16Z

Should be OK to review now. Works with JMC as well. Playlist: https://www.youtube.com/watch?v=PDf2mqxOeMk&list=PLj8NeDWnVAdAu5X5hzioxLdSOhYSvrXTF , feel free to tweet however you like as a list or separately.

…(attributes)

rhuss · 2020-03-30T07:52:37Z

Sorry, didn't make it last week :( So next try is this week ....

client/jmx-adapter/src/main/java/org/jolokia/client/jmxadapter/RemoteJmxAdapter.java

rhuss

Thank @skarsaune for this awesome PR and equally for your patience ;)

It looks good to me, with some minor mostly cosmetic comments and suggestions. If you could address these in this week we can merge it (hint: I have PTO for the rest of the week :)

The only thing missing then is documentation, I will have a look where to best hook in documentation for the JmxAdapter.

thanks!

...nt/jmx-adapter/src/main/java/org/jolokia/client/jmxadapter/JolokiaJmxConnectionProvider.java

client/jmx-adapter/src/main/java/org/jolokia/client/jmxadapter/JolokiaJmxConnector.java

rhuss · 2020-05-12T07:57:57Z

client/jmx-adapter/src/main/java/org/jolokia/client/jmxadapter/JolokiaJmxConnector.java

+    Map<String, Object> mergedEnv = mergedEnvironment(env);
+    String internalProtocol = "http";
+    if (String.valueOf(this.serviceUrl.getPort()).endsWith("443") || "true"
+        .equals(mergedEnv.get("jmx.remote.x.check.stub"))) {


Any particular reason why the environment is called like this? For me it's not obvious that this environment variable relates to select https as protocol. If this is not a standard variable, maybe we can choose some name which indicates its usage ?

Do you refer to "jmx.remote.x.check.stub"? It is used by JConsole. I can create a named constant if that is the case?

I see. I'm ok with using it literally here, maybe a comment would be nice as it is not obvious that this is defined bei JConsole.

client/jmx-adapter/src/main/java/org/jolokia/client/jmxadapter/JolokiaJmxConnector.java

client/jmx-adapter/src/main/java/org/jolokia/client/jmxadapter/RemoteJmxAdapter.java

client/jmx-adapter/src/main/java/org/jolokia/client/jmxadapter/ToOpenTypeConverter.java

…/ToOpenTypeConverter.java Co-authored-by: Roland Huß <rhuss@redhat.com>

…/RemoteJmxAdapter.java Co-authored-by: Roland Huß <rhuss@redhat.com>

…njdk jvms 7-14

rhuss · 2020-06-19T09:14:02Z

@skarsaune thanks a lot ! Looks we are ready to merge now :)

Wrt/ the documentation we can add a followup PR, so that we then can make a release.

Thanks again for your awesome work!

rhuss · 2020-06-19T11:25:42Z

client/jmx-adapter/src/test/java/org/jolokia/client/jmxadapter/JmxBridgeTest.java

+    Assert.assertEquals(
+        this.adapter.getDefaultDomain(), nativeServer.getDefaultDomain(), "Default domain");
+
+    Assert.assertEquals(this.adapter.agentVersion, "1.6.2");


@skarsaune I think this will give us some headaches when releasing. We should either remove this test or make it at parameterised with a property from the pom.xml

skarsaune and others added 14 commits February 7, 2020 09:17

Adding support for running JMX over a Jolokia bridge

86922f4

Signed-off-by: Martin Skarsaune <martin@skarsaune.net>

Test queryNames

0617dd4

simplified query assistance, added documentation

209be1c

Test object instances, and unsupported methods

ae095a0

And support the overall stuff

3262fb7

More handling of composite types, and more granular control of what c…

8f8602c

…an be tested 1:1 , a few tests still remain

More beaninfo tests (in progress)

a751526

More exception mapping and tests

ac30b6c

More exception flows

3801671

More test coverage, cleaned up a bit, made tests more resillient for …

2599184

…when running in mvn

Fixed internal dependency

701d44a

Fixed internal dependency

62d058b

Adjustments for java 7

43d68aa

More java7 test adjustments

430438d

skarsaune force-pushed the jmx_adapter branch from be351bc to 430438d Compare February 14, 2020 09:07

skarsaune added 2 commits February 14, 2020 10:22

Excluding one more memory attribute for direct comparison

a07479d

exlude one more attribute for direct comparison

2184403

skarsaune requested a review from rhuss February 14, 2020 09:47

introduce caching and sensible operation options

e3e557f

skarsaune added 2 commits February 17, 2020 09:18

Works in progress / exploratory: implement connection provider to fac…

505d48e

…lilitate integration in jmc

Creating JMX Connection provider that allows direct use from jconsole…

b4a65d5

… and jvisualvm by adding to classpath (DOES NOT work particularly well at this stage)

Revert client/java/pom.xml

1f8040b

skarsaune added 2 commits February 18, 2020 21:20

Do not sabotage providers of other protocols, use an actual RMI conne…

b8447a4

…ction as reference connection

Adding JMX and jolokia to JConsole and jvisualvm test scripts, JConso…

54c4c5a

…le adjustments

JMC compliance, specify type of certain central MBeans across target …

939d277

…vms, and allow values in payload not covered

skarsaune added 2 commits February 29, 2020 22:15

Allow overriding what connecion is instantiated, format code

ec1a6bb

More adjustments to work better in JMC

517d526

skarsaune added 6 commits March 2, 2020 16:03

Adding simpler test scripts

24b05c3

Handle more error scenarios discovered testing with kubernetes

c2bad31

Ensure common options are also used when calling multiple operations …

90f5916

…(attributes)

Refactor connector to make it easier for subclasses

bce8427

Tolerate diferent naming of visualvm in check

2a4716d

More complete testing for platform mbeans with focus on proxy clients

309ebd1

skarsaune mentioned this pull request Mar 23, 2020

Kubernetes connector #434

Merged

Support for some central jfr classes

30c1b7b

rhuss mentioned this pull request Mar 30, 2020

Failed to retrieve RMIServer stub: javax.naming.ServiceUnavailableException #435

Closed

skarsaune added 2 commits April 6, 2020 15:27

Support for retrieving list of recordings in JMC

31b1129

Support flight recordings in Java Mission Control

59e3b47

skarsaune commented Apr 7, 2020

View reviewed changes

client/jmx-adapter/src/main/java/org/jolokia/client/jmxadapter/RemoteJmxAdapter.java Show resolved Hide resolved

rhuss reviewed May 12, 2020

View reviewed changes

skarsaune and others added 6 commits May 27, 2020 16:50

Update client/jmx-adapter/src/main/java/org/jolokia/client/jmxadapter…

167de76

…/ToOpenTypeConverter.java Co-authored-by: Roland Huß <rhuss@redhat.com>

Update client/jmx-adapter/src/main/java/org/jolokia/client/jmxadapter…

315ce90

…/RemoteJmxAdapter.java Co-authored-by: Roland Huß <rhuss@redhat.com>

Update client/jmx-adapter/src/main/java/org/jolokia/client/jmxadapter…

ec5cab6

…/RemoteJmxAdapter.java Co-authored-by: Roland Huß <rhuss@redhat.com>

Update client/jmx-adapter/src/main/java/org/jolokia/client/jmxadapter…

979d810

…/RemoteJmxAdapter.java Co-authored-by: Roland Huß <rhuss@redhat.com>

Update client/jmx-adapter/src/main/java/org/jolokia/client/jmxadapter…

63fee00

…/RemoteJmxAdapter.java Co-authored-by: Roland Huß <rhuss@redhat.com>

Review fixes: better error messages and supporting all oracle and ope…

f90d303

…njdk jvms 7-14

rhuss merged commit e969126 into jolokia:master Jun 19, 2020

rhuss reviewed Jun 19, 2020

View reviewed changes

dboreham mentioned this pull request Aug 6, 2021

Document Configuring JMX Adapter #471

Open

andrewazores mentioned this pull request Oct 8, 2021

[Story] Jolokia Compatibility cryostatio/cryostat#683

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jmx adapter #431

Jmx adapter #431

skarsaune commented Feb 13, 2020

rhuss commented Feb 14, 2020

skarsaune commented Feb 15, 2020

skarsaune commented Feb 18, 2020

rhuss commented Feb 18, 2020

rhuss commented Feb 18, 2020

skarsaune commented Feb 18, 2020

rhuss commented Feb 29, 2020

skarsaune commented Mar 1, 2020

rhuss commented Mar 30, 2020

rhuss left a comment

rhuss May 12, 2020

skarsaune Jun 16, 2020

rhuss Jun 19, 2020

rhuss commented Jun 19, 2020

rhuss Jun 19, 2020

Jmx adapter #431

Jmx adapter #431

Conversation

skarsaune commented Feb 13, 2020

rhuss commented Feb 14, 2020

skarsaune commented Feb 15, 2020

skarsaune commented Feb 18, 2020

rhuss commented Feb 18, 2020

rhuss commented Feb 18, 2020

skarsaune commented Feb 18, 2020

rhuss commented Feb 29, 2020

skarsaune commented Mar 1, 2020

rhuss commented Mar 30, 2020

rhuss left a comment

Choose a reason for hiding this comment

rhuss May 12, 2020

Choose a reason for hiding this comment

skarsaune Jun 16, 2020

Choose a reason for hiding this comment

rhuss Jun 19, 2020

Choose a reason for hiding this comment

rhuss commented Jun 19, 2020

rhuss Jun 19, 2020

Choose a reason for hiding this comment