New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JVM agent cleanup fix for v1.1.3 #116

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@jhermann
Contributor

jhermann commented Sep 18, 2013

The relevant change is in CleanupThread.java, it adds another non-daemon thread that should be ignored, created by Tanuki JSW and serving the exact same purpose as Jolokia's shutdown thread (they're effectively blocking each other).

jhermann added some commits Sep 18, 2013

Fix race condition during shutdown causing a NPE.
From the getThreadGroup() Javadoc:
	Returns the thread group to which this thread belongs.
	This method returns null if this thread has died (been stopped).
@jhermann

This comment has been minimized.

Contributor

jhermann commented Sep 20, 2013

Also fixed a possible NPE in cleanup, see commit message.

@rhuss

This comment has been minimized.

Owner

rhuss commented Sep 20, 2013

Thanks for the patch, I'll will have look at the weekend.

rhuss added a commit that referenced this pull request Sep 27, 2013

@rhuss

This comment has been minimized.

Owner

rhuss commented Sep 27, 2013

I added you fix manually. Thanks !

@rhuss rhuss closed this Sep 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment