New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better version detection of Payara Server #281

Merged
merged 1 commit into from Oct 4, 2016

Conversation

Projects
None yet
3 participants
@savage-engineer
Contributor

savage-engineer commented Sep 7, 2016

Currently Jolokia will detect Payara Server's version, but will still supply the product name as glassfish and the vendor name as Oracle. My proposed change separates the patterns out so that Payara Server is detected better.

The detector will check first for Glassfish and then for Payara Server.

Fraser Savage
Detection of server and vendor name for Payara Server
Using constants for prod and vendor instead of string literals

Signed-off-by: Fraser Savage <fraser.savage@payara.fish>

@savage-engineer savage-engineer force-pushed the savage-engineer:master branch from 79d7718 to b600795 Sep 13, 2016

@davsclaus

This comment has been minimized.

davsclaus commented Sep 21, 2016

@rhuss looks good to me

@rhuss rhuss merged commit 12ab616 into rhuss:master Oct 4, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rhuss

This comment has been minimized.

Owner

rhuss commented Oct 4, 2016

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment