Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better version detection of Payara Server #281

Merged
merged 1 commit into from Oct 4, 2016
Merged

Better version detection of Payara Server #281

merged 1 commit into from Oct 4, 2016

Conversation

@savage-engineer
Copy link
Contributor

@savage-engineer savage-engineer commented Sep 7, 2016

Currently Jolokia will detect Payara Server's version, but will still supply the product name as glassfish and the vendor name as Oracle. My proposed change separates the patterns out so that Payara Server is detected better.

The detector will check first for Glassfish and then for Payara Server.

Using constants for prod and vendor instead of string literals

Signed-off-by: Fraser Savage <fraser.savage@payara.fish>
@davsclaus
Copy link

@davsclaus davsclaus commented Sep 21, 2016

@rhuss looks good to me

@rhuss rhuss merged commit 12ab616 into rhuss:master Oct 4, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rhuss
Copy link
Owner

@rhuss rhuss commented Oct 4, 2016

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants