Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an aliased tag to find binary on Windows to fix recent fails on Neovim (stable) on Windows #5

Closed
lambdalisue opened this issue Aug 8, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@lambdalisue
Copy link

It seems Neovim does not supply the binary for Windows in stable release.

neovim 2020-08-08 15-50-54

It's happened again and again so it would be nice if the action refers stable and solve it's same with 0.4.4 or whatever and check the resource on aliased tags. Not sure if it's possible or not.

@lambdalisue
Copy link
Author

I've made an issue report on the Neovim side to fix the current situation.
neovim/neovim#12730

But I prefer if action-setup-vim can handle above situation by itself.

@rhysd
Copy link
Owner

rhysd commented Aug 24, 2020

I'm sorry that I missed this issue. I will look into this.

@rhysd rhysd added the bug Something isn't working label Aug 24, 2020
@rhysd
Copy link
Owner

rhysd commented Aug 24, 2020

At this point, all artifacts seem there:

スクリーンショット 2020-08-24 23 47 19

I guess there are some timing where some artifacts lack. For example, new stable release has been created but building artifacts is ongoing. I did not see this issue on stable, but I did on nightly release. I guess nightly has more frequency because it is built daily.

I think implementing fallback to the nearest stable release (0.4.4 at this time for example) would be good idea as you pointed.

@rhysd rhysd added enhancement New feature or request and removed bug Something isn't working labels Aug 24, 2020
@rhysd rhysd closed this as completed in bf797db Sep 8, 2020
@lambdalisue
Copy link
Author

Thanks 🎉

@rhysd
Copy link
Owner

rhysd commented Sep 19, 2020

Please let me know if the issue is still there in your environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants