Using html

[mifi]

Nice module!

Would be nice to have the option to put HTML inside the attributes (like description)

[rhysd]

Could you show me some code snippet example? Let's discuss based on code.

[mifi]

Example:

openAboutWindow({
  icon_path: join(__dirname, 'icon.png'),
  description: '<b>Some bold test</b><a href="myawesomeapp.com">See more here</a>.'
                            })

Currently it just renders the html markup as text, because in the code you're using innerText (https://github.com/rhysd/electron-about-window/blob/master/src/renderer.ts#L30)
Could maybe use innerHTML instead.

[rhysd]

Thanks. I think implementation is very simple as you said. Let me think if there is no risk about XSS because of setting inner HTML.

[rhysd]

I noticed that your example doesn't work. <a> tag navigates to your project page in the 'About Me' window. The window is not protected with sandbox. So we should not navigate to any external page in the window. We need to open the page in external browser.

Regarding to your use case, is it also acceptable to add 'See more' link to description?

[rhysd]

I added a link to application's homepage to application's name instead of adding 'see more' to description because longer description may break the layout. Change is 1e0f5e6.

Does it meet your usecase?

[mifi]

Oh I see. That sounds like a nice addition too (the link.)

Actually the link wasn't a particular use case, more an example. It was more that it would be nice to be able to add custom HTML block, if someone needs to write some more text with formatting in their about page.

[rhysd]

OK, I think we can use will-navigate event to prevent navigation and open the URL with external browser. I'll try to implement

[rhysd]

openAboutWindow({
   icon_path: join(__dirname, 'icon.png'),
   copyright: 'Copyright (c) 2015 rhysd',
   description: 'Hello, world <a href="https://github.com" class="link">(see more)</a>'
})

now opens a window like below:

I added will-navigate hook and new-window hook. So <a> tag will open the link with external browser.

I published v1.5.0.

[mifi]

Great! thanks! However I think changing from innerText to innerHtml is a breaking change, so we should either bump version to 2.0.0 or introduce a flag in order to use innerHtml instead of innerText.
Maybe introduce a property called "useHtml" ?

[rhysd]

Hmm... I think adding new property is better because innerHTML is dangerous. In the case, current behavior is not broken. I'll unpublish 1.5.0 and add useInnerHTML option in 1.6.0.

[mifi]

You can have useInnerHtml property in 1.5 as well, as long as it defaults to innerText, because then it is backwards compatible :)

[rhysd]

Following semantic versioning, we need to up minor version because it's a new feature without breaking change. Anyway, I already published v1.6.0 👍