-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package.json not used if in a different directory #23
Comments
I could not find any problem with your code and my implementation. Could you check this warning message here?: https://github.com/rhysd/electron-about-window/blob/master/src/index.ts#L21 If loading package.json failed, the warning should be shown in terminal because it is executed in main process. |
that error message is not displayed in the terminal |
weird... In example, I used the same props and it works. https://github.com/rhysd/electron-about-window/blob/master/example/main.js#L28-L33 Well, is the project in public? Or if it's just a trial, is it possible to send your project codes to me? (logo can be dummy because it's not related to this issue) |
after much trial and error I decided to start fresh, and everything works as expected. Thanks for the help |
I currently have a directory structure like this
in main.js I have this code
click: () => openAboutWindow({ icon_path: join(__dirname, '/assets/logo.png'), copyright: 'Copyright (c) 2018 www.example.com', package_json_dir: join(__dirname, '..') })
but the generic electron icon is loaded without the attributes that are in package.json
if main.js is moved back to mainFolder, everything works as expected
The text was updated successfully, but these errors were encountered: