Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getName is deprecated in Electron 7 #48

Closed
dtslvr opened this issue Oct 28, 2019 · 3 comments
Closed

getName is deprecated in Electron 7 #48

dtslvr opened this issue Oct 28, 2019 · 3 comments
Labels
bug

Comments

@dtslvr
Copy link

dtslvr commented Oct 28, 2019

I get the following warninig when starting the about window with Electron 7:

'getName function' is deprecated and will be removed. Please use 'name property' instead.

See here: https://github.com/electron/electron/blob/master/docs/api/app.md#appgetname
@rhysd rhysd added the bug label Oct 28, 2019
@rhysd
Copy link
Owner

rhysd commented Nov 7, 2019

This was fixed by #50.

@rhysd rhysd closed this as completed Nov 7, 2019
@dtslvr
Copy link
Author

dtslvr commented Nov 12, 2019

When do you plan the next release?

@rhysd
Copy link
Owner

rhysd commented Nov 13, 2019

I'm sorry for the lag. I'll publish new version tonight (JST).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhysd @dtslvr