Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opens non-existing file page when the latest commit is not pushed yet #12

Closed
rhysd opened this issue Apr 25, 2019 · 1 comment
Closed

Opens non-existing file page when the latest commit is not pushed yet #12

rhysd opened this issue Apr 25, 2019 · 1 comment
Assignees
@rhysd
Labels
bug
Projects
git-brws

Comments

@rhysd
Copy link
Owner

rhysd commented Apr 25, 2019

Repro

cd git-brws
git checkout master
git commit --allow-empty -m hi
git brws README.md

Expected behavior

Opens https://github.com/rhysd/git-brws/blob/master/README.md

Actual behavior

Opens not existing page https://github.com/rhysd/git-brws/blob/xxxxxxx/README.md where xxxxxxx is a commit hash not pushed yet
@rhysd rhysd added the bug label Apr 25, 2019
@rhysd rhysd self-assigned this Apr 25, 2019
@rhysd rhysd added this to Inbox in git-brws Apr 25, 2019
@rhysd rhysd moved this from Inbox to Doing in git-brws Apr 25, 2019
@rhysd rhysd moved this from Doing to Done in git-brws Apr 26, 2019
@rhysd
Copy link
Owner Author

rhysd commented Apr 29, 2019

This was fixed at v0.11.0

@rhysd rhysd closed this as completed Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhysd rhysd

Labels
bug
Projects
git-brws
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rhysd