Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI on X86_64 Windows fails due to bad --git-dir #20

Closed
rhysd opened this issue Feb 4, 2020 · 0 comments
Closed

CI on X86_64 Windows fails due to bad --git-dir #20

rhysd opened this issue Feb 4, 2020 · 0 comments
Labels

Comments

@rhysd
Copy link
Owner

rhysd commented Feb 4, 2020

Job: https://ci.appveyor.com/project/rhysd/git-brws/branch/master/job/2rm5eqvclqhw653f

This failure is only on CI (both Appveyor and GitHub Actions). It is not reproducible on my local Windows machine. All tests passed on my local machine.

.canonicalize() uses \\?... path (extended path length) but it seems not supported by --git-dir. On Windows, --git-dir is not a file path actually. It is a kind of slash-path:

> git rev-parse --absolute-git-dir
D:/a/git-brws/git-brws/.git

\\?\D:\a\git-brws\git-brws\.git for --git-dir seems not available on some version of Windows. Following error occurs at running rev-parse --abbrev-ref --symbolic @{u} command:

fatal: not a git repository: '\\?\C:\git-brws\.git'

Actually it was OK on my local Windows machine to use the \\?... path as far as I tried manually.

@rhysd rhysd added the bug label Feb 4, 2020
@rhysd rhysd closed this as completed in 527bff6 Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant