-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview was closed immediately as soon as it was opened on Vim 8 #16
Comments
In addition, if the cursor is on the top line of the page, this issue will not occur anymore. |
It seems that this plugin does not work on Vim8 correctly. I did not notice that because tests are run only for Neovim for now. On my laptop, |
It seems that this is a problem of behavior of job feature on Vim8. I'll try to make a workaround. |
Wow, it's astonishing. I ever thought it was a preview-windows problem or Vim itself... |
Could you check 8e71f4d fixes this issue? At least on my laptop, it seems to have gone. |
Yes! The problem was solved. Now this plugin works normally on Vim 8. It's awesome! Hmmm, cloud you tell me in brief that how did you found that cause? autocmd CursorMoved,CursorMovedI,InsertEnter <buffer> call <SID>on_cursor_moved() I ever thought the cursor's movement event caused that issue, but it didn't moved, which made me puzzled. How did you directly found that the ringleader is "job's channel hadn't been closed after callback function was called" Thanks. |
I also thought that a cursor move would cause this issue. However, I noticed that window was actually not opened while the issue. I found it by dumping trace data by giving Then I added some debug prints to |
Vim version
This plugin works perfect on Neovim. but on Vim 8, the preview window will crash on the moment it is created if I set
updatetime
to100
.Is this a bug of Vim? Do we have a solution for the problem?
The text was updated successfully, but these errors were encountered: