Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New minor version for ratatui dependencies #18

Closed
AmmarAbouZor opened this issue May 14, 2023 · 7 comments
Closed

New minor version for ratatui dependencies #18

AmmarAbouZor opened this issue May 14, 2023 · 7 comments

Comments

@AmmarAbouZor
Copy link

Hi, at first I want to thank you on this great library. I used it in my app tui-journal and it was a charm!

I came across an issue while trying updating my app to use ratatui instead of tui-rs.

The problem is that cargo didn't recognize the new features for ratatui since they are in save version as before, and it seems that cargo cache this info somewhere in my machine. I've tried to clear my caches but this didn't solve the problem.

I believe the version should be updated to 0.2.1 since there are new features has been added.

Here is the error message I got when I try to add the features with cargo cli

$ cargo add tui-textarea --no-default-features -F ratatui-crossterm

    Updating crates.io index
      Adding tui-textarea v0.2.0 to dependencies.
error: unrecognized feature for crate tui-textarea: ratatui-crossterm
disabled features:
    arbitrary, crossterm, search, termion

And here is the error message when I try to add inside cargo.toml

[dependencies]
crossterm = "0.26.1"
ratatui = "*"
tui-textarea = { version = "*", features = ["ratatui-crossterm"], default-features=false }
error: failed to select a version for `tui-textarea`.
versions that meet the requirements `*` (locked to 0.2.0) are: 0.2.0

the package `test_ratatui` depends on `tui-textarea`, with features: `ratatui-crossterm` but `tui-textarea` does not have these features.

failed to select a version for `tui-textarea` which could resolve this conflict
@AmmarAbouZor
Copy link
Author

@rhysd Would it be helpful if I make a PR for it?

@haydenflinner
Copy link

This solved it for me:

tui-textarea = { git = "https://github.com/rhysd/tui-textarea", features = ["ratatui-crossterm"], default-features=false }

@AmmarAbouZor
Copy link
Author

@haydenflinner This solution will work as long as your app isn't published on crates.io itself, because crates.io doesn't allow having dependencies in your app which source isn't crates.io like git or local dependencies.

That's why this update is a must for all apps that's published on crates.io @rhysd

@danielo515
Copy link

This should be a simple version bump and publishing, right?

@AmmarAbouZor
Copy link
Author

@danielo515
Yes it should be enough to increase the version here (patch or minor) and then publish it to crates.io

Hopefully we'll hear soon from @rhysd 🙏

@TheAwiteb
Copy link

You can use ratatui-textarea a fully supported tui-textarea for ratatui

@AmmarAbouZor
Copy link
Author

The new release of text-area here and on crates.io solved this issue.
Thanks @rhysd ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants