Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async event loop to disable Emterpreter #9

Closed
rhysd opened this issue Jul 10, 2018 · 4 comments
Closed

Async event loop to disable Emterpreter #9

rhysd opened this issue Jul 10, 2018 · 4 comments
Assignees
Labels
enhancement New feature or request
Projects

Comments

@rhysd
Copy link
Owner

rhysd commented Jul 10, 2018

As described in known issues, disabling Emterpreter would make execution more stable and faster. For that, an event loop for waiting user input must be async to use JavaScript's setTimeout().

@rhysd rhysd created this issue from a note in Development (To do) Jul 10, 2018
@rhysd rhysd mentioned this issue Jul 10, 2018
@rhysd rhysd self-assigned this Jul 11, 2018
@rhysd rhysd added the enhancement New feature or request label Jul 13, 2018
@curiousdannii
Copy link

You should at least use a whitelist.

@rhysd
Copy link
Owner Author

rhysd commented Jul 15, 2018

Yeah, I want to use it, but emcc crashes on compilation.

@rhysd
Copy link
Owner Author

rhysd commented Jul 16, 2018

I could identify which function caused the emcc crash and could enable whitelisting. I added a whitelist at 2df338e though it might not be perfect. Now all functions which are not listed in the list are compiled to wasm directly.

@rhysd rhysd moved this from To do to In progress in Development Jul 26, 2018
@rhysd
Copy link
Owner Author

rhysd commented Jun 12, 2019

This was fixed by #30. Emterpreter is no longer used. So we don't need to rewrite functions to async.

@rhysd rhysd closed this as completed Jun 12, 2019
Development automation moved this from In progress to Done Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants