Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Find a better solution for situations where a log_prefix is not provided for the S3 Bucket #9

Open
dgoodellrhy opened this issue Jul 21, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@dgoodellrhy
Copy link
Contributor

Is your feature request related to a problem? Please describe.
If you don't specify a log_prefix for the S3 logging bucket, each time the pipeline runs AWS generates a new prefix based on the pipeline name and SSM Execution hash, and the end result is that your logs go into unpredictably names prefixes that aren't easy to sort by date, and are maybe impossible to identify unless you get an error message from the pipeline explaining where the logs were sent.

Describe the solution you'd like
I don't know, maybe just override an empty log_prefix with the pipeline name? Anything is better than the default behavior I think.

Describe alternatives you've considered
I mean, we're technically taking away functionality by forcing a prefix, in case there's anyone out there who wants to do things the bad way? We could leave it as is and rely on making logs more easy to access another way (cloudwatch? I don't know)

Additional context
you told me to make this issue in slack! so i did.

@dgoodellrhy dgoodellrhy added the enhancement New feature or request label Jul 21, 2020
@cdaniluk
Copy link
Contributor

Would this be better handled in documentation? It isn’t our job to make the implementation not stupid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants