Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions now only download the last 14 days worth of episodes. #150

Closed
ribbons opened this issue Aug 22, 2013 · 2 comments
Closed

Subscriptions now only download the last 14 days worth of episodes. #150

ribbons opened this issue Aug 22, 2013 · 2 comments
Assignees
Labels
bug Something isn't working fixed
Milestone

Comments

@ribbons
Copy link
Owner

ribbons commented Aug 22, 2013

Original report from brianhanson at 16:57:23 on 2011-07-22

There are some regular arts programmes, like Front Row & Night Waves, which are never properly described in Radio Times, and which are ideally subscribed to on Radio Downloader, so that the full content of each programme can be consulted before deciding to listen or not.

However, such programmes retain hundreds of episodes on file (Front Row offers episodes going back 11 years!), and subscribing to them inevitably gums up my downloads; even brings my computer to a halt. Cleaning up the ones I don't need takes forever. Would it be possible to have a limited download option for programmes (eg. "from now on") in addition to the Full Works?


Imported from Bug 523 in the NerdoftheHerd.com Bugzilla.

@ghost ghost assigned ribbons Aug 22, 2013
@ribbons
Copy link
Owner Author

ribbons commented Aug 22, 2013

Original comment from Matt Robinson at 15:40:19 on 2011-07-31

I've been giving this some thought lately, as although issue #100 will address the problem of not being able to check / un-check all of the episodes in the available episodes list (and therefore will allow subscribing to only future episodes), this doesn't solve the issue of people accidentally downloading hundreds of episodes as part of subscribing to a programme.

I think probably the best solution would be to make the per-episode auto-download checkboxes have three states internally, un-set (which would be the default, and appear as checked), checked, and un-checked. The subscription download logic could then be adjusted to only download checked episodes, and un-set episodes broadcast within the last 14 days.

However, this will also require the functionality to update episode data described in issue #151 to be in place before it can be implemented to prevent issues with previously encountered episodes not being downloaded due to being outside of the 14 day window.

@ribbons
Copy link
Owner Author

ribbons commented Aug 22, 2013

Original comment from Matt Robinson at 17:19:28 on 2012-07-22

I realised since my last comment that having three states internally isn't necessary, all that needed to be changed is updating the subscription code to only download episodes from the last fortnight. As multiple-select is now available in the episodes list, users wanting to download all of the back-episodes of a subscription can do this manually by selecting them all and choosing 'Download'.

Added the 14 day cut-off to the subscription code in de58e27.

@ribbons ribbons closed this as completed Aug 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed
Projects
None yet
Development

No branches or pull requests

1 participant