Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved handling and clean-up of temporary files used by the providers. #171

Closed
ribbons opened this issue Aug 22, 2013 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request fixed
Milestone

Comments

@ribbons
Copy link
Owner

ribbons commented Aug 22, 2013

Original report from Matt Robinson at 21:01:31 on 2012-04-08

There are currently a few issues relating to temporary files (e.g. intermediate files used by the providers):

  • Interrupted downloads can leave behind large temporary files
  • Temporary files still in use by one of the dependency applications can cause a download to error (even though the file could just be cleaned up later)
  • Corrupt temporary files, or those with messed up permissions can cause issues retrying downloads as the same file name is re-used for the temporary files of a specific download.
  • The files are contained within a folder in the temp directory which may get removed, or acquire strange permissions.

Imported from Bug 635 in the NerdoftheHerd.com Bugzilla.

@ghost ghost assigned ribbons Aug 22, 2013
@ribbons
Copy link
Owner Author

ribbons commented Aug 22, 2013

Original comment from Matt Robinson at 17:26:26 on 2012-05-11

Reworked in 8ef35f2 to use a new class called TempFile to handle temporary files used by the providers. This generates unique names under the temp folder, and guarantees that the files will be cleaned up, but will wait until a later occasion if the file is still in use when it is first attempted to be deleted.

@ribbons ribbons closed this as completed Aug 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed
Projects
None yet
Development

No branches or pull requests

1 participant