Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed download failures on Windows with long generated episode filenames #239

Closed
ribbons opened this issue May 5, 2020 · 0 comments
Closed
Assignees
Labels
bug Something isn't working fixed
Milestone

Comments

@ribbons
Copy link
Owner

ribbons commented May 5, 2020

If an episode is assigned a path and filename longer than 260 characters, the download fails under Windows when attempting to move the file to the final destination with the following exception:

The specified path, file name, or both are too long. The fully qualified file name must be less than 260 characters, and the directory name must be less than 248 characters.

System.IO.PathTooLongException
   at System.IO.Path.SafeSetStackPointerValue(Char* buffer, Int32 index, Char value)
   at System.IO.Path.NormalizePathFast(String path, Boolean fullCheck)
   at System.IO.Path.GetFullPathInternal(String path)
   at System.IO.File.Move(String sourceFileName, String destFileName)
   at PodcastProvider.PodcastProvider.DownloadProgramme(String progExtId, String episodeExtId, ProgrammeInfo progInfo, EpisodeInfo epInfo, String finalName) in C:\projects\radiodownloader\Providers\PodcastProvider\Classes\PodcastProvider.cs:line 443
   at RadioDld.DownloadHandler.DownloadProgThread() in C:\projects\radiodownloader\Classes\DownloadHandler.cs:line 221

This is most likely to be caused by a very long podcast episode name, but could also be hit using unusual episode name templates or a long root save folder path.

@ribbons ribbons added the bug Something isn't working label May 5, 2020
@ribbons ribbons added this to the 0.36 milestone May 5, 2020
@ribbons ribbons self-assigned this May 5, 2020
@ribbons ribbons changed the title Download failures can be caused by long generated episode filenames Download failures can be caused on Windows by long generated episode filenames May 5, 2020
@ribbons ribbons added the fixed label Aug 30, 2020
@ribbons ribbons changed the title Download failures can be caused on Windows by long generated episode filenames Fixed download failures on Windows with long generated episode filenames Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed
Projects
None yet
Development

No branches or pull requests

1 participant