New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misplaced / wrong else in opengraph partial #107

Closed

DanielRuf opened this issue Nov 26, 2020 · 0 comments

Collaborator

DanielRuf commented Nov 26, 2020

I guess this else closes the IfPage block:

https://github.com/ribice/kiss/blob/master/layouts/partials/social/opengraph.html#L38

It should be probably moved under the og:image:

{{- with .Params.image -}}
  <meta property='og:image' content='{{ . | absURL }}'>
{{- else -}}
  {{- with .Site.Params.Social.email -}}
    <meta property='og:image' content='https://www.gravatar.com/avatar/
            {{- . | md5 -}}
            ?s=256'>
  {{- end -}}
{{- end -}}

The text was updated successfully, but these errors were encountered:

DanielRuf closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment