Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird test failures #86

Closed
skalee opened this issue Jan 30, 2020 · 1 comment
Closed

Weird test failures #86

skalee opened this issue Jan 30, 2020 · 1 comment
Assignees
@skalee

Comments

@skalee
Copy link
Contributor

skalee commented Jan 30, 2020 •
edited
Loading

ActiveRecord feature specs fail in GitHub Actions for Ruby 2.5.7, Rails 6.0.2, and WITHOUT="mongoid". Failure has been replicated by re-running it a couple of times.

This is really odd, especially that the same test on the same Ruby and Rails but WITHOUT="" succeeds. Looks like some race condition, or that examples interfere with each other.

https://github.com/riboseinc/attr_masker/runs/417065415?check_suite_focus=true
@skalee skalee self-assigned this Jan 30, 2020
@skalee
Copy link
Contributor Author

skalee commented Jan 30, 2020

Fixed in #88. Detailed explanation is in the pull request.

@skalee skalee closed this as completed Jan 30, 2020
@skalee skalee mentioned this issue Jan 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skalee skalee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skalee