-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vagrant for testing purpose #7
Comments
Fully agree! 👍 |
You probably meant Travis? I’m wondering how we can actually test since it involves AWS. We will have to separately test the Terraform module, the Lambda scripts, and also the client scripts. |
I think we dont need to make calls to AWS API since the main task is building Signature v4 which is depends on OpenSSL. I wonder if there is any incompatible OpenSSL version that @erikbor fixed. We can use aws signature-v4-test-suite Issue submitted riboseinc/terraform-aws-authenticating-secgroup#13 to discuss terraform module testing |
I was working with @erikbor yesterday and we fixed it for OpenSSL 1.1. Not sure if it works for OpenSSL 1.0.x though. |
Yep, thats exactly whats we need to do test |
We also should add build badge as well
The text was updated successfully, but these errors were encountered: