Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vagrant for testing purpose #7

Open
4 tasks
phuonghuynh opened this issue Jan 6, 2018 · 5 comments
Open
4 tasks

Vagrant for testing purpose #7

phuonghuynh opened this issue Jan 6, 2018 · 5 comments
Assignees

Comments

@phuonghuynh
Copy link
Contributor

phuonghuynh commented Jan 6, 2018

We also should add build badge as well

  • Ubuntu
  • MacOS High Sierra
  • RHEL
  • CentOS
@ronaldtse
Copy link

Fully agree! 👍

@ronaldtse
Copy link

You probably meant Travis? I’m wondering how we can actually test since it involves AWS. We will have to separately test the Terraform module, the Lambda scripts, and also the client scripts.

@phuonghuynh
Copy link
Contributor Author

phuonghuynh commented Jan 6, 2018

I think we dont need to make calls to AWS API since the main task is building Signature v4 which is depends on OpenSSL. I wonder if there is any incompatible OpenSSL version that @erikbor fixed.

We can use aws signature-v4-test-suite

Issue submitted riboseinc/terraform-aws-authenticating-secgroup#13 to discuss terraform module testing

@ronaldtse
Copy link

I was working with @erikbor yesterday and we fixed it for OpenSSL 1.1. Not sure if it works for OpenSSL 1.0.x though.

@phuonghuynh
Copy link
Contributor Author

Yep, thats exactly whats we need to do test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants