New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(highlight): add poimandres theme #302
Conversation
🦋 Changeset detectedLatest commit: 01cc5fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Someone is attempting to deploy a commit to a Personal Account owned by @riccardoperra on Vercel. @riccardoperra first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @Kalmarv, nice work! |
To answer you for the EDIT: Also updated the README of the highlight package and put the theme name in rollup config is not needed anymore (automatically retrieves themes from directories), I've resolved the conflicts 😄 |
Alright, updated it with those changes. That script looks way better btw, I searched the entire repo with a theme name to figure out all the files I had to change 😅 |
Perfect :) will release it tomorrow. Thank you |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #301
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Let me know if any changes are needed. There was a few more files I had to edit to add the theme, so people can refer to this if they're adding themes in the future.