Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(highlight): add poimandres theme #302

Merged
merged 6 commits into from Jul 13, 2022

Conversation

Kalmarv
Copy link
Contributor

@Kalmarv Kalmarv commented Jul 13, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #301

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Let me know if any changes are needed. There was a few more files I had to edit to add the theme, so people can refer to this if they're adding themes in the future.

poimandres

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2022

🦋 Changeset detected

Latest commit: 01cc5fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@codeimage/app Patch
@codeimage/highlight Patch
@codeimage/config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 13, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @riccardoperra on Vercel.

@riccardoperra first needs to authorize it.

@vercel
Copy link

vercel bot commented Jul 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
codeimage ✅ Ready (Inspect) Visit Preview Jul 13, 2022 at 10:17PM (UTC)

@vercel vercel bot temporarily deployed to Preview July 13, 2022 04:13 Inactive
@riccardoperra
Copy link
Owner

Hi @Kalmarv, nice work!
I've just add some comments to try to improve the highlighting 😄 ty

@vercel vercel bot temporarily deployed to Preview July 13, 2022 18:08 Inactive
@riccardoperra
Copy link
Owner

riccardoperra commented Jul 13, 2022

To answer you for the Other information paragraph, I've just updated the main branch with a script which automatically generate all the files a2ab82d

EDIT: Also updated the README of the highlight package and put the theme name in rollup config is not needed anymore (automatically retrieves themes from directories), I've resolved the conflicts 😄

@vercel vercel bot temporarily deployed to Preview July 13, 2022 18:12 Inactive
@Kalmarv
Copy link
Contributor Author

Kalmarv commented Jul 13, 2022

Alright, updated it with those changes.

That script looks way better btw, I searched the entire repo with a theme name to figure out all the files I had to change 😅

@vercel vercel bot temporarily deployed to Preview July 13, 2022 22:15 Inactive
@vercel vercel bot temporarily deployed to Preview July 13, 2022 22:17 Inactive
@riccardoperra riccardoperra merged commit 9700b71 into riccardoperra:main Jul 13, 2022
@riccardoperra
Copy link
Owner

Perfect :) will release it tomorrow. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants