Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove emitters from Store #5

Closed
ricejasonf opened this issue Feb 27, 2016 · 1 comment
Closed

Remove emitters from Store #5

ricejasonf opened this issue Feb 27, 2016 · 1 comment

Comments

@ricejasonf
Copy link
Owner

Right now Stores have the responsibility of emitting changes to listeners via the StoreEmitter. When a message is given to a store, it would probably be better to have it simply indicate whether that message should be propagated further upstream/downstream and let the Context pass it on.

This would make pub/sub requirements (if any) completely up to the Consumers, which eliminates the need to create custom StoreEmitters that would probably have logic specific to a given Consumer anyways.

@ricejasonf
Copy link
Owner Author

e1dec1f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant