Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security: SafeKey XSS #19

Closed
JohannesLamberts opened this issue Apr 12, 2019 · 2 comments · Fixed by #20
Closed

Security: SafeKey XSS #19

JohannesLamberts opened this issue Apr 12, 2019 · 2 comments · Fixed by #20

Comments

@JohannesLamberts
Copy link

As shown in vuejs/vuex-router-sync#89 (comment) and https://codesandbox.io/s/5x2wpo27k4, devalue exposes a XSS vulnerability, when an object key contains unsafe characters.

From the issue:

I think it should be safe to use the same approach as in serialize-javascript to replace unsafe characters: https://github.com/yahoo/serialize-javascript/blob/35f64803a3a67662e16ad5260901d4e291260989/index.js#L126
@pi0
Copy link
Contributor

pi0 commented Apr 13, 2019 •
edited
Loading

Simpler reproduction:

Server-side (express + query):

This was referenced Apr 13, 2019
Merged
Merged
@Rich-Harris
Copy link
Owner

Thank you for finding/fixing this — bit embarrassed about how long it went unmerged, but this is now released as 1.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: escape unsafe object keys pi0/devalue
3 participants
@Rich-Harris @pi0 @JohannesLamberts