-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cran integration #7
Comments
Yes. Plan to get that underway this week. Hope beyond hope that will be a smooth process... Would love to see a sample of that use later on if that's possible. |
Not yet finished but of course I will send it to you when written. The ML package I am working on is from the ensemble tree family, meaning the model uses several decision trees to take a decision. Therefore I will need to plot several trees. To give you an idea, this is a txt dump of a simple model:
Each booster is an independant decision tree usually focusing on a part of the data not learned by the previous trees. The f[number] is an id which will be replaced by the name of a feature used to split the tree, the yes=, no= ... is the key to understand the relation between the branch of the tree, and the gain is a metric of the importance of the feature in the decision tree. |
Would really like to see the functionality proposed and also like to see I do think thought that |
I have tried and it was easy to have several graph on the same image. That s a very good thing. |
@pommedeterresautee could you perhaps post just the code + example of "Basically I parse the text model with some regex and convert it to a data.table." somewhere? Sorry to thread-jack |
@mostly-harmless my WIP code is here: https://github.com/pommedeterresautee/xgboost/blob/master/R-package/R/xgb.plot.tree.R The file read is the one I posted 2 posts ago. Just put the content in a text file, change the path and generate the Viz. @rich-iannone @timelyportfolio |
I like the direction this conversation is headed. To separate from CRAN integration, I thought it might be good to start issue #8 for
|
@mostly-harmless function is complete. |
Thanks @pommedeterresautee ! |
Thanks again @pommedeterresautee, that's great! |
@rich-iannone did you find time to submit your package to cran? |
@pommedeterresautee there is still a problem building the vignette. I need to resolve that issue before submitting to CRAN. |
Okay, @pommedeterresautee and @timelyportfolio, figured out the build issue with the vignette, I had a slightly older version of knitr. Once I updated that, I could build the vignette and building the source package was free of errors. I'll submit to CRAN. |
Now submitted to CRAN. Just need to wait for a reply from BDR. |
After a few rounds of fixes, it's now in CRAN. |
Awesome I push my code on XGBoost! First reverse dependency for DiagrammeR :-) |
That is great to hear! Thanks @pommedeterresautee for all the help and interest so far. |
I am working on a plot function for this ML package https://github.com/tqchen/xgboost (I want to plot the tree model generated). I think DiagrammeR is perfect for this job.
However it would require a new dependency from Xgboost R package to your package and I can't do it properly until your package is pushed to Cran. Therefore, do you plan to push your package to Cran?
Kind regards,
Michaël
The text was updated successfully, but these errors were encountered: