Chapter 4 in Hungarian #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry about the confusion on that one, YAML parsers are extremely poor right now when it comes to conversion of long text :) definitely format the long text however you think appropriate. |
|
Oh yeah, no problem at all, I just wanted to make sure. |
richardanaya
approved these changes
Jul 15, 2020
|
So cool seeing these all in one file now :P |
|
Absolutely! Great change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like the new system, however, I'd like to ask for a bit of clarification. How should we exactly format these yaml files? When i started editing chapter 4, I saw a lot of seemingly senseless line-breaks in the original version. I ultimately chose to go with line-breaks only where I actually want them to happen.
Anyway, pull introduces Chapter 4 in Hungarian.