safeFileName

[AlexNodex]

When safeFileName is set to true in the options, it removes the dot from the file extension thus rendering the extension useless, it might be an idea to allow dots also.

[bchr02]

that would explain why I am getting an unsupported MIME type error

[AlexNodex]

I really do hope the lib doesn't rely on file extension to set mime type, that would be extremely insecure to rely on !!

…

Sent from my iPhone

On 2 Mar 2017, at 19:41, Bill Christo ***@***.***> wrote: that would explain why I am getting an unsupported MIME type error — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[bchr02]

I believe the MIME type error was coming from another lib that I am using in conjunction with express-fileupload as a result of the file extension missing..

[richardgirges]

I really do hope the lib doesn't rely on file extension to set mime type, that would be extremely insecure to rely on !!

@AlexNodex that is certainly not the case. express-fileupload uses busboy to detect mime types. :)

As for this issue, thanks for bringing it up - it will be resolved in an upcoming release real soon.

[richardgirges]

New release: v0.1.3 has been published to NPM. A new feature, courtesy of @pronein addresses this issue.

You can now pass in preserveExtension as an option in the express-fileupload middleware. Example usage:

app.use(fileUpload({ safeFileNames: true, preserveExtension: true }));

Read more detail about the feature on the README.