Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security patches and updates #316

Open
richardgirges opened this issue May 24, 2022 · 5 comments
Open

Security patches and updates #316

richardgirges opened this issue May 24, 2022 · 5 comments

Comments

@richardgirges
Copy link
Owner

There have been some unconfirmed security reports raised by @harunoz. This ticket will track the decisions and fixes (if any) to address all open security reports.

There are five primary areas that are covered in Harun's reports:

  • File Naming (currently reviewing)
  • Spoofing (currently reviewing)
  • Polyglot files
  • PDF files
  • File overwriting : this has been confirmed to be a non-issue. In the report, the user is intentionally implementing bad practices, such as uploading file contents into areas of the filesystem where sensitive files, such as source files, are present. It is up to the user of express-fileupload to ensure that files placed with the .mv method are placed in a secure location where they cannot cause harm regardless of the filename or extension.
@duterte
Copy link
Contributor

duterte commented May 24, 2022

Would you like to share some details so we could also help on it ?

@richardgirges
Copy link
Owner Author

@duterte can you email me at richardgirges - a t - gmail dot com? I will send you the report

@Fryguy
Copy link

Fryguy commented Jun 15, 2023

@richardgirges While you are reviewing these, I think it might be helpful to reach out to NIST/Mitre and request that these CVEs be marked as disputed. At the moment, all security scanning tools flag this issue as super-mega-critical, which is unfortunate. To mark it as disputed, you just have to message them here: https://cveform.mitre.org/

@Fryguy
Copy link

Fryguy commented Jun 30, 2023

@richardgirges - CVE-2022-27140 is now marked as disputed in NIST's database

** DISPUTED ** ... NOTE: the vendor's position is that the observed behavior can only occur with "intentional misusing of the API": the express-fileupload middleware is not responsible for an application's business logic (e.g., determining whether or how a file should be renamed).

@boxexchanger
Copy link

Hi, someone know developers works on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants