Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wikidata TrID results do not have the same provenance metadata as other results resulting in large numbers of linting messages #160

Open
ross-spencer opened this issue Mar 21, 2021 · 0 comments
Assignees
Labels

Comments

@ross-spencer
Copy link
Collaborator

Working out the fix for #153 I am seeing a lot of Wikidata linting messages appear for the new TrID patterns. It is because the SPARQL for provenance expected more uniformity.

We need:

        optional { ?object prov:wasDerivedFrom ?provenance;
           optional { ?provenance pr:P248 ?reference. }
           optional { ?provenance pr:P813 ?date. }

but were using:

        optional { ?object prov:wasDerivedFrom ?provenance;
           optional { ?provenance pr:P248 ?reference;
                                  pr:P813 ?date.
                    }
        }

This has the unfortunate result of being an incomplete graph if ?date isn't available for the provenance for a record. E.g. the record for Gherkin files.

We'll change the SPARQL to the above and that should be okay but need to verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants