Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity.clone() - possible error if component registered with BaseClass #15

Closed
neilmanuell opened this issue Feb 7, 2013 · 1 comment

Comments

@neilmanuell
Copy link
Contributor

line no 154:
copy.add( newComponent );
assumes that all components being cloned are referenced against their Class, not a BaseClass

ie:
copy.add( newComponent, ComponentBaseClass );

I don't think that this method is used within the framework, so any errors probably won't occur very often.

I shall write a test to prove this, then write a patch

@neilmanuell
Copy link
Contributor Author

sorry, I hadn't realised that that the pull request would add an issue
am closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant