feat(dist): minimise the size of the package for browsers

BREAKING CHANGE: The fallback Intl package is no longer included in browsers. To use it see https://github.com/andyearnshaw/Intl.js#intljs-and-ft-polyfill-service
richardschneider · Nov 4, 2016 · 389df68 · 389df68
1 parent ee51bae
commit 389df68
Show file tree

Hide file tree

Showing 5 changed files with 41 additions and 5 deletions.
diff --git a/browser.js b/browser.js
@@ -1,5 +1,5 @@
 'use strict';
 
-require('babel-polyfill');
+//require('babel-polyfill');
 
 module.exports = require('./lib/money');
diff --git a/lib/l10n.js b/lib/l10n.js
@@ -2,8 +2,13 @@
 
 /* global Intl */
 
-const fallbackIntl = require('intl'),
-      memoize = require('memoize-immutable');
+const memoize = require('memoize-immutable');
+
+/* The fallback Intl is not shipped to a browser. */
+var fallbackIntl = require('intl');
+if (!('NumberFormat' in fallbackIntl)) {
+    fallbackIntl = null;
+}
 
 var fallbackLanguage; // 'undefined' lets the enviroment determine the best language
 var defaults = {
@@ -20,7 +25,7 @@ function currencyFormat(language, currency, options) {
         currency = language;
         language = fallbackLanguage;
     }
-    if (language) {
+    if (language && fallbackIntl) {
         let supported = i18n.NumberFormat.supportedLocalesOf(language)[0] === language;
         if (!supported) {
             i18n = fallbackIntl;

diff --git a/package.json b/package.json
@@ -5,7 +5,10 @@
   "bugs": "https://github.com/richardschneider/money-works/issues",
   "license": "MIT",
   "main": "index.js",
-  "browser": "browser.js",
+  "browser": {
+      "index.js": "browser.js",
+      "intl": false
+  },
   "browserify": {
     "transform": [
       [

diff --git a/test/l10n.js b/test/l10n.js
@@ -12,4 +12,8 @@ describe('Localisation', () => {
         a.should.not.equal(c);
     });
 
+    it('should accept any language', () => {
+        let a = l10n('xx-XX', 'EUR');
+        a.should.have.property('format');
+    });
 });
diff --git a/test/runner.html b/test/runner.html
@@ -0,0 +1,24 @@
+<!DOCTYPE html>
+<html>
+<head>
+  <meta charset="utf-8">
+  <title>Testing money-works</title>
+  <style>
+    body {
+       font: 18px/1.5 "Helvetica Neue", Helvetica, sans-serif;
+       padding-left: 20px;
+    }
+  </style>
+  <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/mocha/3.0.2/mocha.css" />
+</head>
+<body>
+  <div id="mocha"></div>
+
+  <script src="https://cdnjs.cloudflare.com/ajax/libs/mocha/3.0.2/mocha.js"></script>
+  <script>mocha.setup('bdd');</script>
+  <script src="../dist/money-works.spec.js"></script>
+  <script>
+    mocha.run();
+  </script>
+</body>
+</html>