fix(forex): better error message when exchange rate is undefined

richardschneider · Nov 19, 2016 · c85acb5 · c85acb5
1 parent ae73372
commit c85acb5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/money.js b/lib/money.js
@@ -186,6 +186,9 @@ Money.prototype.to = function to(currency) {
         .forexService(self.currency, currency)
         .then(rate => {
             try {
+                if (rate === undefined) {
+                    return Promise.reject(new Error(`Undefined exchange rate for ${self.currency} to ${currency}`));
+                }
                 return new Money(self.amount.times(rate), currency);
             } catch (e) {
                 return Promise.reject(e);

diff --git a/test/money.js b/test/money.js
@@ -362,7 +362,7 @@ describe('Money', () => {
             let nzd = new Money('100 NZD');
             Money.forexService = () => Promise.resolve(undefined);
             return nzd.to('CNY')
-                .should.be.rejected();
+                .should.be.rejectedWith({ message: "Undefined exchange rate for NZD to CNY" });
         });
 
         it('should reject an exchange rate that is not a number', () => {