Skip to content

Commit

Permalink
chore: remove dead code
Browse files Browse the repository at this point in the history
netstandard14 is no longer supported.  Conditionals for SharpZipLib
are no longer needed.
  • Loading branch information
richardschneider committed Jun 15, 2019
1 parent 0104614 commit e3c8dc0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 16 deletions.
12 changes: 1 addition & 11 deletions src/IpfsEngine.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -58,22 +58,12 @@
<PackageReference Include="PeterO.Cbor" Version="3.1.0" />
<PackageReference Include="Portable.BouncyCastle" Version="1.8.5" />
<PackageReference Include="protobuf-net" Version="2.4.0" />
<PackageReference Include="SharpZipLib" Version="1.0.0" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0-beta2-19270-01" PrivateAssets="All" />
<PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="16.0.102" PrivateAssets="All" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'netstandard14'">
<PackageReference Include="System.Security.SecureString">
<Version>4.3.0</Version>
</PackageReference>
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' != 'netstandard14'">
<PackageReference Include="SharpZipLib">
<Version>1.0.0</Version>
</PackageReference>
</ItemGroup>
</Project>
6 changes: 1 addition & 5 deletions test/CoreApi/FileSystemApiTest.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
#if !NETCOREAPP1_1 // TODO
using ICSharpCode.SharpZipLib.Tar;
#endif
using ICSharpCode.SharpZipLib.Tar;
using Ipfs.CoreApi;
using Microsoft.VisualStudio.TestTools.UnitTesting;
using System;
Expand Down Expand Up @@ -762,7 +760,6 @@ public async Task Read_From_OtherNode()
}
}

#if !NETCOREAPP1_1 // TODO
[TestMethod]
public async Task GetTar()
{
Expand Down Expand Up @@ -852,7 +849,6 @@ public async Task GetTar_EmptyDirectory()
Directory.Delete(temp, true);
}
}
#endif

[TestMethod]
public async Task Isssue108()
Expand Down

0 comments on commit e3c8dc0

Please sign in to comment.