Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing NuGet package pulls in lots of unwanted "dependencies" #13

Closed
sjmorgan81 opened this issue Aug 30, 2019 · 2 comments
Closed

Comments

@sjmorgan81
Copy link

My project is targeting .NET Framework 4.6.1 and when I go to install RT.Comb 2.3.0 I get the following prompt to install a load of dependencies for code that's already part of the .NET standard library:

image

I think this issue might be fixable by either bumping the version of .NET Standard you target to 2.0 (I'm using Dapper which targets 2.0 and don't have this issue) or adding another entry to <TargetFrameworks> as discussed here.

@richardtallent
Copy link
Owner

I think you're right. I haven't had a chance to look at this, but I will be moving it to .NET Standard 2.0 soon. I use Dapper as well, and I have projects targeting both .NET Core and .NET 4.7.2 using this library.

@richardtallent
Copy link
Owner

The library targets .NET Standard 2.0, and the tests and other command-line tools now target .NET 5.0, so this should no longer be an issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants