Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.1.6 breaks IE11 compatibility #2

Closed
jonathanmoffatt opened this issue Dec 6, 2018 · 3 comments
Closed

0.1.6 breaks IE11 compatibility #2

jonathanmoffatt opened this issue Dec 6, 2018 · 3 comments

Comments

@jonathanmoffatt
Copy link

Hi Richard,
This commit in 0.1.6 breaks IE11 compatibility. Works fine still against 0.1.5.

@richardtallent
Copy link
Owner

Sorry for the late reply... I don't have access to test IE11 anymore, can you provide more information?

@OmgImAlexis, since you authored the module support added in 0.1.6, would you be able to provide some insight on this?

@OmgImAlexis
Copy link
Contributor

OmgImAlexis commented Dec 18, 2018

@jonathanmoffatt you'll likely need to use the babel-plugin-transform-es2015-arrow-functions babel plugin.

The reason you need this is that IE11 doesn't support fat arrows.

@richardtallent
Copy link
Owner

Ah! Since we don't strictly need an fat arrow, I've reverted it back to a plain old function. Published as 0.1.7. @jonathanmoffatt, please re-open if this doesn't resolve the issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants